Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with invalid SpanContext are recorded. #3928

Merged
merged 10 commits into from
May 7, 2024
Merged

Links with invalid SpanContext are recorded. #3928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9df5bf2
Links with invalid SpanContext are recorded by default.
carlosalberto Mar 7, 2024
6d706c2
Apply feedback.
carlosalberto Mar 14, 2024
3776a4f
Merge branch 'main' into keep-invalid-links
carlosalberto Mar 14, 2024
dcaec27
Update CHANGELOG.
carlosalberto Mar 14, 2024
1b85580
Update CHANGELOG.md
carlosalberto Mar 14, 2024
fcd940e
Merge branch 'main' into keep-invalid-links
carlosalberto Apr 15, 2024
2138d66
Minor clarification.
carlosalberto Apr 17, 2024
d2c76dc
Update specification/trace/api.md
carlosalberto May 1, 2024
55baab9
Merge branch 'main' into keep-invalid-links
carlosalberto May 1, 2024
7af0f6e
Merge branch 'main' into keep-invalid-links
carlosalberto May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/trace/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,8 @@ The API MUST provide:
arguments. This MAY be called `AddLink`. This API takes the `SpanContext` of
the `Span` to link to and optional `Attributes`, either as individual
parameters or as an immutable object encapsulating them, whichever is most
appropriate for the language. Implementations MAY ignore links with an
[invalid](#isvalid) `SpanContext`.
appropriate for the language. Implementations SHOULD record links with an
[invalid](#isvalid) `SpanContext` as well.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved

The Span interface MAY provide:

Expand Down
4 changes: 4 additions & 0 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ Note: Implementation-wise, this could mean that `Tracer` instances have a
reference to their `TracerProvider` and access configuration only via this
reference.

A boolean parameter indicating whether `Links` with invalid `SpanContext`
are recorded or not SHOULD be exposed as part of the configuration,
with true as its default value.

carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
### Shutdown

This method provides a way for provider to do any cleanup required.
Expand Down
Loading