Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework metric signal overview #3916

Merged

Conversation

jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Feb 29, 2024

Continuing #3900

Changes

The Metric signal overview was outdated, referencing classes that no longer exist.

  • Added overview of Meter instruments
  • Added section about views
  • Updated wording / descriptions

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup. Thanks for taking the work to make this more understandable!

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR as I already reviewed it in #3900.

@reyang reyang merged commit 3cfd5ad into open-telemetry:main Mar 5, 2024
7 checks passed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants