Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Remove implementation detail from Logs Bridge API #3884

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 16, 2024

The bridge-api.md document specifies the Logs Bridge API, it does not defined the OpenTelemetry defined implementations of this API. Remove this detail from the API and leave it for the implementation specification to define.

Importantly, the API is decoupled from implementation for a reason. Third-party implementation may exists that OTel does not have domain over. This document needs to written with that in mind.

Related to #3171 and #3071 which were similar issues resolved for the metric API definition.

The bridge-api.md document specifies the Logs Bridge API, it does not
defined the OpenTelemetry defined implementations of this API. Remove
this detail from the API and leave it for the implementation
specification to define.

Importantly, the API is decoupled from implementation for a reason.
Third-party implementation may exists that OTel does not have domain
over. This document needs to written with that in mind.
@MrAlias MrAlias added the spec:logs Related to the specification/logs directory label Feb 16, 2024
@MrAlias MrAlias requested review from a team February 16, 2024 17:41
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry? Thanks!

@reyang reyang merged commit 6fd4f08 into open-telemetry:main Feb 28, 2024
7 checks passed
@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Feb 28, 2024
jaydeluca pushed a commit to jaydeluca/opentelemetry-specification that referenced this pull request Feb 29, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants