Refine description of Instrumentation Scope for Logs #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
reviewed
Jan 31, 2024
MrAlias
approved these changes
Jan 31, 2024
reyang
reviewed
Feb 1, 2024
Co-authored-by: Reiley Yang <[email protected]>
jack-berg
reviewed
Feb 13, 2024
jack-berg
approved these changes
Feb 20, 2024
pellared
changed the title
pellared
changed the title
tigrannajaryan
requested changes
Feb 27, 2024
|
@tigrannajaryan PTAL. I addressed your comment. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…3855) Fixes open-telemetry#3841 ## Changes - Update "Instrumentation Scope" term in glossary. - Update "Attribute Collections" (in common definitions) to include instrumentation scope attributes. - Change the instrumentation scope type definition from `(Name,Version) tuple of strings` to Instrumentation Scope definition (as the current definition misses Scheme URL and Attributes). - Refer to `InstrumentationScope` Data Model field in Bridge API to make the spec easier to follow. - Move the part relevant to Bridge API usage from the Data Model. - Remove "Version is optional. Name SHOULD be specified if version is specified, otherwise Name is optional." which should act as recommendation in the API. But the API already contains information how the parameters should be used. --------- Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3841
Changes
(Name,Version) tuple of stringsto Instrumentation Scope definition (as the current definition misses Scheme URL and Attributes).InstrumentationScopeData Model field in Bridge API to make the spec easier to follow.