Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications and "flexibility" fixes in Exemplar Specification #3760

Merged
merged 15 commits into from
Dec 1, 2023

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Nov 10, 2023

Fixes #2205
Fixes #3674
Fixes #3669
Partially fixes #2421

Changes

  • Update example exemplar algorithm to account for initial reservoir fill
  • Update fixed-size defaults to account for memory contention / optimization in Java impl
  • Set a default for exponential histogram aggregation
  • Clarify that ExemplarFilter should be configured on MeterProvider
  • Make it clear that ONE reservoir is create PER timeseries datapoint (not one reservoir per view or metric name).
  • Allow flexibility in Reservoir offer definition based on feedback from Go impl.

- Update fixed-size defaults to account for memory
  contention/optimisation.
- Fix open-telemetry#3674: Set a default for exponential histograms.
- Make it clear that one reservoir is created PER timeseries point.
- Allow flexibility in Reservoir definition, based on feedback from Go
  SIG - open-telemetry#3669
@jsuereth jsuereth requested review from a team November 10, 2023 21:05
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Show resolved Hide resolved
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 25, 2023
@MrAlias MrAlias removed the Stale label Nov 28, 2023
@jmacd jmacd merged commit bb3d0a0 into open-telemetry:main Dec 1, 2023
7 checks passed
@jsuereth jsuereth deleted the wip-exemplar-clarifications branch December 4, 2023 15:22
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…n-telemetry#3760)

Fixes open-telemetry#2205
Fixes open-telemetry#3674 
Fixes open-telemetry#3669
Partially fixes open-telemetry#2421

## Changes

- Update example exemplar algorithm to account for initial reservoir
fill
- Update fixed-size defaults to account for memory contention /
optimization in Java impl
- Set a default for exponential histogram aggregation
- Clarify that ExemplarFilter should be configured on MeterProvider
- Make it clear that ONE reservoir is create PER timeseries datapoint
(not one reservoir per view or metric name).
- Allow flexibility in Reservoir `offer` definition based on feedback
from Go impl.

* Related issues open-telemetry#3756

---------

Co-authored-by: David Ashpole <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants