ParentBased is a decorator #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Sep 27, 2023
|
|
I am not in favor of using explicitly object-oriented language to describe things in the specification given many languages that implement it are not object-oriented. Also, the implementation of this sampler can quite literally be a decision hierarchy tree matching what you define as "composite". I think the current definition is correct. |
|
Decorator is a design pattern that means "modifies behavior of underlying thing without changing its interface". A function can decorate another function, there's nothing inherently object-oriented about it. In contrast, "composite" means containing more than one other things, and doesn't imply anything about the resulting interface. In the context of ParentBased sampler decorator is a better term. |
tigrannajaryan
approved these changes
Sep 27, 2023
pellared
referenced
this pull request
in open-telemetry/opentelemetry.io
Sep 27, 2023
trask
approved these changes
Sep 28, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
ParentBased sampler is decorator (and not a composite). > The intent of a composite is to "compose" objects into tree structures to represent part-whole hierarchies. > What problems can the Composite design pattern solve? > [...] > A part-whole hierarchy should be represented as tree structure `ParentBased` does not produce a tree. Composite aims to solve a different (but kind of similar) problem. > decorator pattern [...] that allows behavior to be added to an individual [object](https://en.wikipedia.org/wiki/Object_(computer_science)), dynamically, without affecting the behavior of other objects from the same [class](https://en.wikipedia.org/wiki/Class_(computer_science)). > What problems can it solve? > Responsibilities should be added to (and removed from) an object dynamically at run-time.[5] >>A flexible alternative to subclassing for extending functionality should be provided. The key feature of the `ParentBased` is how it changes the "behavior" of the wrapped sampler. We decorate the existing sampler so that it handles the sampling based on the parent's span. References: - https://en.wikipedia.org/wiki/Decorator_pattern - https://en.wikipedia.org/wiki/Composite_pattern - https://sourcemaking.com/design_patterns/composite - https://sourcemaking.com/design_patterns/decorator - https://stackoverflow.com/questions/2233952/difference-between-the-composite-pattern-and-decorator-pattern Related issue open-telemetry/opentelemetry-go#4565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParentBased sampler is decorator (and not a composite).
ParentBaseddoes not produce a tree. Composite aims to solve a different (but kind of similar) problem.The key feature of the
ParentBasedis how it changes the "behavior" of the wrapped sampler. We decorate the existing sampler so that it handles the sampling based on the parent's span.References:
Related issue open-telemetry/opentelemetry-go#4565