Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "/" to valid characters for instrument names #3684

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Add "/" to valid characters for instrument names #3684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d994745
Add "/" to valid characters for instrument names
aabmass Sep 7, 2023
85b878a
Reset compatibility matrix row for 'Instrument names conform to the s…
aabmass Sep 11, 2023
16c88aa
Merge branch 'main' into allow-slash-3422
aabmass Sep 11, 2023
fc8ab8a
Fix formatting of matrix
aabmass Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ release.
([#3662](https://github.com/open-telemetry/opentelemetry-specification/pull/3662))
- Clarify the minimal implementation of a `View`'s `attribute_keys` is an allow-list.
([#3680](https://github.com/open-telemetry/opentelemetry-specification/pull/3680))
- Add "/" to valid characters for instrument names
([#3684](https://github.com/open-telemetry/opentelemetry-specification/pull/3684))

### Logs

Expand Down
2 changes: 1 addition & 1 deletion spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ formats is required. Implementing more than one format is optional.
| A valid instrument MUST be created and warning SHOULD be emitted when multiple instruments are registered under the same `Meter` using the same `name`. | | | + | + | + | | | | | | | |
| Duplicate instrument registration name conflicts are resolved by using the first-seen for the stream name. | | | + | | | | | | | | | |
| It is possible to register two instruments with same `name` under different `Meter`s. | | + | + | + | + | | | | + | + | + | |
| Instrument names conform to the specified syntax. | | - | + | | + | | | | + | + | + | |
| Instrument names conform to the specified syntax. | | | | | | | | | | | + | |
| Instrument units conform to the specified syntax. | | - | + | | + | | | | + | + | + | |
| Instrument descriptions conform to the specified syntax. | | - | + | | - | | | | | - | + | |
| Instrument supports the advisory ExplicitBucketBoundaries parameter. | | | + | | | | | | | | | |
Expand Down
6 changes: 3 additions & 3 deletions specification/metrics/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ The instrument name syntax is defined below using the [Augmented Backus-Naur
Form](https://tools.ietf.org/html/rfc5234):

```abnf
instrument-name = ALPHA 0*254 ("_" / "." / "-" / ALPHA / DIGIT)
instrument-name = ALPHA 0*254 ("_" / "." / "-" / "/" / ALPHA / DIGIT)
reyang marked this conversation as resolved.
Show resolved Hide resolved

ALPHA = %x41-5A / %x61-7A; A-Z / a-z
DIGIT = %x30-39 ; 0-9
Expand All @@ -215,8 +215,8 @@ DIGIT = %x30-39 ; 0-9
* They are not null or empty strings.
* They are case-insensitive, ASCII strings.
* The first character must be an alphabetic character.
* Subsequent characters must belong to the alphanumeric characters, '_', '.',
and '-'.
* Subsequent characters must belong to the alphanumeric characters, '_', '.', '-',
and '/'.
* They can have a maximum length of 255 characters.

#### Instrument unit
Expand Down
Loading