Skip to content

Fix missing delta export and a typo in supplementary guidelines #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented Aug 22, 2023

Changes

I think in #3242 when updating the supplementary guidelines, we lost the initial export for one of the delta examples. I didn't see it when the original PR was open.

CC @dashpole, could you check if this is correct or whether I am missing something?

The second change just removes a redundant a, since I just stumbled across it I thought I'd remove it while I am at it.

@pirgeo pirgeo requested review from a team August 22, 2023 11:50
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Aug 22, 2023
@reyang reyang merged commit f624c03 into open-telemetry:main Aug 22, 2023
@pirgeo pirgeo deleted the pirgeo-patch-1 branch August 23, 2023 06:27
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants