Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jaeger exporter #3567

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 26, 2023

Fixes #3551

Changes

Please provide a brief description of the changes here.

  • Updated CHANGELOG
  • Removed the Jaeger exporter and related configuration
  • Removed entries from the spec compliance matrix.

@marcalff
Copy link
Member Author

marcalff commented Jun 26, 2023

To @open-telemetry/specs-trace-approvers @yurishkuro

This PR removes the Jaeger Exporter from the specification, as it was scheduled for removal in July 2023, as announced by:

[EDIT 2023-06-23: revisited item (1) and (2) per review comments]

(1) In my understanding, now that trace data is no longer exported in Jaeger format (Jaeger can accept OTLP directly), there should no longer be a use case to have a Jaeger Propagator. As a result, this change removes the JaegerPropagator specifications as well.

(1) The Jaeger Propagator specification is unchanged, per clarifications from Yuri.

(2) Also in my understanding, the mapping (specification/trace/sdk_exporters/jaeger.md) from OTLP to Jaeger format is no longer needed, as no code will ever perform this transformation, so the mapping is also removed from the specification.

(2) The mapping (specification/trace/sdk_exporters/jaeger.md) from OTLP to Jaeger format is preserved in the specification.

(3) On a related topic, the specification also mention the Jaeger Remote Sampler. I left the spec for the remote sampler as is, assuming the remote sampler and the export format are orthogonal concerns, i.e., it still makes sense to have remote sampling even when traces are exported in OTLP, not Jaeger, format.

Please let me know if I missed something, in particular in (1), (2) and (3), and I will adjust the patch accordingly.

@marcalff marcalff marked this pull request as ready for review June 26, 2023 14:55
@marcalff marcalff requested review from a team June 26, 2023 14:55
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaeger propagator has no relation to the export data format. Once a propagation format is rolled out in a company, changing it is quite expensive and cannot be done without dual writing phase. In contrast, switching export format can be easily done incrementally.

CHANGELOG.md Outdated Show resolved Hide resolved
Fixed review comments.
@marcalff
Copy link
Member Author

Jaeger propagator has no relation to the export data format. Once a propagation format is rolled out in a company, changing it is quite expensive and cannot be done without dual writing phase. In contrast, switching export format can be easily done incrementally.

Thanks for the comments.

The PR is now revised as follows:

  • the Jaeger Exporter is removed
  • the Jaeger Propagator is untouched (previous changes are rolled back)
  • the Jaeger Remote Sampler is untouched

Please take another look.

opentelemetry-cpp will also preserve the Jaeger Propagator then.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop jaeger exporter
6 participants