-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jaeger exporter #3567
Remove jaeger exporter #3567
Conversation
To @open-telemetry/specs-trace-approvers @yurishkuro This PR removes the Jaeger Exporter from the specification, as it was scheduled for removal in July 2023, as announced by: [EDIT 2023-06-23: revisited item (1) and (2) per review comments]
(1) The Jaeger Propagator specification is unchanged, per clarifications from Yuri.
(2) The mapping ( (3) On a related topic, the specification also mention the Jaeger Remote Sampler. I left the spec for the remote sampler as is, assuming the remote sampler and the export format are orthogonal concerns, i.e., it still makes sense to have remote sampling even when traces are exported in OTLP, not Jaeger, format. Please let me know if I missed something, in particular in (1), (2) and (3), and I will adjust the patch accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jaeger propagator has no relation to the export data format. Once a propagation format is rolled out in a company, changing it is quite expensive and cannot be done without dual writing phase. In contrast, switching export format can be easily done incrementally.
Fixed review comments.
Thanks for the comments. The PR is now revised as follows:
Please take another look. opentelemetry-cpp will also preserve the Jaeger Propagator then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fixes #3551
Changes
Please provide a brief description of the changes here.