Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Metrics SDK env vars as Stable #3530

Closed
wants to merge 2 commits into from

Conversation

pellared
Copy link
Member

@pellared pellared commented Jun 2, 2023

It looks like OTEL_METRICS_EXEMPLAR_FILTER is pretty stable. Java, Python, PHP are already implementing it.

Nothing is explicitly marked as Experimental.

@pellared pellared marked this pull request as ready for review June 2, 2023 12:34
@pellared pellared requested review from a team June 2, 2023 12:34
@arminru arminru added area:sdk Related to the SDK area:configuration Related to configuring the SDK spec:metrics Related to the specification/metrics directory labels Jun 2, 2023
@@ -303,7 +303,7 @@ Known values for `OTEL_LOGS_EXPORTER` are:

## Metrics SDK Configuration

**Status**: [Mixed](../document-status.md)
**Status**: [Stable](../document-status.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exemplars themselves are still experimental, so I don't think we should mark these as stable yet.

@cijothomas
Copy link
Member

From a quick look, Python does not seem to have implemented Exemplars at all.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still uncertainty around the values of this environment variable: #2421

I'm not sure we want to stabilize prior to that issue being resolved.

@pellared
Copy link
Member Author

pellared commented Jun 2, 2023

I will try to make a PR to make it visible that this is experimental.

@pellared pellared closed this Jun 2, 2023
@pellared
Copy link
Member Author

pellared commented Jun 2, 2023

I created #3533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants