Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Remove http.status_code attribute from the http.server.active_requests metric #3366

Merged
merged 4 commits into from
Apr 7, 2023
Merged

BREAKING: Remove http.status_code attribute from the http.server.active_requests metric #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba56769
Remove http.status_code attribute from http.server.active_requests me…
trask Apr 4, 2023
939c26c
Add change log entry
trask Apr 4, 2023
cbda14c
Regenerate tables
trask Apr 4, 2023
6f532a0
Merge branch 'main' into fix-active-requests
reyang Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ release.
([#3347](https://github.com/open-telemetry/opentelemetry-specification/pull/3347))
- Change `db.statement` to only be collected if there is sanitization.
([#3127](https://github.com/open-telemetry/opentelemetry-specification/pull/3127))
- BREAKING: Remove `http.status_code` attribute from the
`http.server.active_requests` metric.
([#3366](https://github.com/open-telemetry/opentelemetry-specification/pull/3366))

### Compatibility

Expand Down
1 change: 0 additions & 1 deletion semantic_conventions/metrics/http.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ groups:
unit: "{request}"
attributes:
- ref: http.method
- ref: http.status_code
- ref: http.scheme
- ref: net.host.name
requirement_level: required
Expand Down
1 change: 0 additions & 1 deletion specification/metrics/semantic_conventions/http-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ This metric is optional.
|---|---|---|---|---|
| `http.method` | string | HTTP request method. | `GET`; `POST`; `HEAD` | Required |
| `http.scheme` | string | The URI scheme identifying the used protocol. | `http`; `https` | Required |
| `http.status_code` | int | [HTTP response status code](https://tools.ietf.org/html/rfc7231#section-6). | `200` | Conditionally Required: If and only if one was received/sent. |
| [`net.host.name`](../../trace/semantic_conventions/span-general.md) | string | Name of the local HTTP server that received the request. [1] | `localhost` | Required |
| [`net.host.port`](../../trace/semantic_conventions/span-general.md) | int | Port of the local HTTP server that received the request. [2] | `8080` | Conditionally Required: [3] |

Expand Down