Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underspecified and unused Span decorator from Trace SDK. #3363

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Remove underspecified and unused Span decorator from Trace SDK. #3363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77c8edd
Remove underspecified and unused Span decorator from Trace SDK.
tsloughter Apr 4, 2023
c46d149
Merge branch 'main' into rm-decorators
arminru Apr 5, 2023
470122a
Merge branch 'main' into rm-decorators
arminru Apr 5, 2023
ed9f562
Merge branch 'main' into rm-decorators
reyang Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ release.

### Traces

* Clarify required parent information in ReadableSpan. Technically a relaxation,
- Clarify required parent information in ReadableSpan. Technically a relaxation,
but previously it was easy to overlook certain properties were required.
[#3257](https://github.com/open-telemetry/opentelemetry-specification/pull/3257)
- Remove underspecified and unused Span decorator from Trace SDK.
([#3363](https://github.com/open-telemetry/opentelemetry-specification/pull/3363))

### Metrics

Expand Down
3 changes: 1 addition & 2 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,7 @@ Each processor registered on `TracerProvider` is a start of pipeline that consis
of span processor and optional exporter. SDK MUST allow to end each pipeline with
individual exporter.

SDK MUST allow users to implement and configure custom processors and decorate
built-in processors for advanced scenarios such as tagging or filtering.
SDK MUST allow users to implement and configure custom processors.

The following diagram shows `SpanProcessor`'s relationship to other components
in the SDK:
Expand Down