Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove No-Op instrument and Meter creation restrictions #3322

Merged
merged 11 commits into from
Apr 4, 2023
Merged

Remove No-Op instrument and Meter creation restrictions #3322

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0e89e58
Remove No-Op inst and Meter create restrictions
MrAlias Mar 17, 2023
fea11f0
Merge branch 'main' into metric-noop-create-alt
reyang Mar 20, 2023
4c30780
Update CHANGELOG.md
MrAlias Mar 20, 2023
e3ca46b
Merge branch 'main' into metric-noop-create-alt
MrAlias Mar 23, 2023
6e8ec57
Merge branch 'main' into metric-noop-create-alt
MrAlias Mar 27, 2023
8f37bf5
Merge branch 'main' into metric-noop-create-alt
MrAlias Mar 29, 2023
0a271d5
Merge branch 'main' into metric-noop-create-alt
MrAlias Mar 29, 2023
2f2d1ae
Merge branch 'main' into metric-noop-create-alt
MrAlias Apr 3, 2023
07d131c
Merge branch 'main' into metric-noop-create-alt
MrAlias Apr 3, 2023
e6245ec
Merge branch 'main' into metric-noop-create-alt
MrAlias Apr 3, 2023
3e650ed
Merge branch 'main' into metric-noop-create-alt
jmacd Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ release.

- Clarify that units should use UCUM case sensitive variant.
([#3306](https://github.com/open-telemetry/opentelemetry-specification/pull/3306))
- Remove No-Op instrument and Meter creation requirements.
([#3322](https://github.com/open-telemetry/opentelemetry-specification/pull/3322))
- Fixed attributes requirement level in semantic conventions for hardware metrics
([#3258](https://github.com/open-telemetry/opentelemetry-specification/pull/3258))

Expand Down
24 changes: 0 additions & 24 deletions specification/metrics/noop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ any argument it receives.

## Meter

A Meter is always created by a MeterProvider. The No-Op MUST NOT provide
a way for a user to create a Meter other than by a No-Op MeterProvider.

The Meters created by the No-Op need to hold as small a memory
footprint as possible. Therefore, all Meters created MUST NOT hold
configuration or operational state.
Expand Down Expand Up @@ -190,9 +187,6 @@ telemetry.

### Counter

Counters are always created by a Meter, the No-Op MUST NOT provide a way
for a user to create a Counter other than by a No-Op Meter.

Counters MUST NOT return a non-empty error or log any message for any
operations they perform.

Expand All @@ -206,9 +200,6 @@ state about the arguments it receives.

### UpDownCounter

UpDownCounters are always created by a Meter, the No-Op MUST NOT provide
a way for a user to create a UpDownCounter other than by a No-Op Meter.

UpDownCounters MUST NOT return a non-empty error or log any message for
any operations they perform.

Expand All @@ -223,9 +214,6 @@ state about the arguments it receives.

### Histogram

Histograms are always created by a Meter, the No-Op MUST NOT provide a
way for a user to create a Histogram other than by a No-Op Meter.

Histograms MUST NOT return a non-empty error or log any message for any
operations they perform.

Expand All @@ -239,10 +227,6 @@ any state about the arguments it receives.

### Asynchronous Counter

Asynchronous Counters are always created by a Meter, the No-Op MUST NOT
provide a way for a user to create a Asynchronous Counter other than by
a No-Op Meter.

Asynchronous Counters MUST NOT return a non-empty error or log any
message for any operations they perform.

Expand All @@ -256,10 +240,6 @@ about observations made for the instrument.

### Asynchronous UpDownCounter

Asynchronous UpDownCounters are always created by a Meter, the No-Op
MUST NOT provide a way for a user to create a Asynchronous UpDownCounter
other than by a No-Op Meter.

Asynchronous UpDownCounters MUST NOT return a non-empty error or log any
message for any operations they perform.

Expand All @@ -273,10 +253,6 @@ state about observations made for the instrument.

### Asynchronous Gauge

Asynchronous Gauges are always created by a Meter, the No-Op MUST NOT
provide a way for a user to create a Asynchronous Gauge other than by a
No-Op Meter.

Asynchronous Gauges MUST NOT return a non-empty error or log any message
for any operations they perform.

Expand Down