Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpc examples to include grpc namespace #3211

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix rpc examples to include grpc namespace #3211

merged 1 commit into from
Feb 15, 2023

Conversation

arminru
Copy link
Member

@arminru arminru commented Feb 15, 2023

The attribute was renamed in #2981 but the Examples column was not adjusted to match.

Replaces #3208 - thanks @loganfsmyth!

@arminru arminru requested review from a team February 15, 2023 10:47
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Feb 15, 2023
@arminru arminru added editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:trace Related to the specification/trace directory labels Feb 15, 2023
@reyang reyang merged commit 285f368 into open-telemetry:main Feb 15, 2023
@arminru arminru deleted the rpc-grpc branch February 15, 2023 18:19
@loganfsmyth
Copy link

Thanks!

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@arminru
Fix rpc examples to include grpc namespace (open-telemetry#3211)
7bf6fd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@trask trask trask approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:semantic-conventions Related to semantic conventions editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arminru @loganfsmyth @trask @carlosalberto @reyang