-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify how to collect host.id for non-containerized systems #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
force-pushed
the
host-id-conventions
branch
from
February 2, 2023 23:37
9b59e8a
to
a67b2b6
Compare
mwear
force-pushed
the
host-id-conventions
branch
from
February 2, 2023 23:40
a67b2b6
to
315b9f7
Compare
carlosalberto
approved these changes
Feb 4, 2023
svrnm
reviewed
Feb 6, 2023
svrnm
reviewed
Feb 6, 2023
mwear
force-pushed
the
host-id-conventions
branch
from
February 7, 2023 00:06
3da0fb0
to
8ccf15e
Compare
This was referenced Feb 10, 2023
svrnm
approved these changes
Feb 13, 2023
arminru
added
area:semantic-conventions
Related to semantic conventions
spec:resource
Related to the specification/resource directory
labels
Feb 14, 2023
arminru
approved these changes
Feb 14, 2023
This was referenced Feb 27, 2023
jmacd
approved these changes
Feb 27, 2023
dmitryax
approved these changes
Feb 28, 2023
arminru
approved these changes
Feb 28, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:semantic-conventions
Related to semantic conventions
spec:resource
Related to the specification/resource directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies how to collect
host.id
for non-containerized systems. The spec currently states:This PR expands upon that by specifying how to collect the
host.id
for Linux, BSD, MacOS, and Windows. This update also acknowledges that some systems may wish to collect thehost.id
via methods that require elevated privileges (such asdmidecode
), but restricts resource detector implementations to non-privileged lookups.