-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws lambda spec to remove X-Ray Env propagation #3166
Conversation
Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators. We also decided that `EventToCarrier` should be specified in the spec to improve cross language instrumentation consistency.
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tristan Sloughter <[email protected]>
Pulled section about EventToCarrier for further discussion.
@Aneurysm9 note: I pulled the section about |
fyi @tedsuo we have a spec reviewer block here |
Approved by AWS Lambdas SME's - @Aneurysm9 |
No GCP or Azure SME input required |
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
…ambda.md Co-authored-by: Tyler Yahn <[email protected]>
…ambda.md Co-authored-by: Tyler Yahn <[email protected]>
This has enough approvals but merging is blocked because there are unresolved conversations. |
@tigrannajaryan thanks for the call-out. I've resolved the remaining conversation. Should be good to go! |
@tyler Forgot to mention we need a CHANGELOG entry as well 😓 |
ad7244f
to
7c30584
Compare
7c30584
to
744bb9f
Compare
open-telemetry/opentelemetry-specification#3166 Per discussion in the FAAS SIG, we decided that the AWS X-Ray environment variable should be moved to a span link to avoid interfering with the configured propagators.
…7970) open-telemetry/opentelemetry-specification#3166 Per discussion in the FAAS SIG, we decided that the AWS X-Ray environment variable should be moved to a span link to avoid interfering with the configured propagators. Also related to #5167.
May I know the deeper reason why changing parent-child to be links? |
@wangzlei This PR is probably not the best place to have this discussion. Can I suggest you open a new issue or join the FAAS SIG meeting? The quick summary is that the prior behavior would break traces for other vendors when x-ray was enabled because the x-ray internal spans were not available. |
@wangzlei As Tyler said, please open an issue in https://github.com/open-telemetry/semantic-conventions (and maybe join the FaaS call? We meet every Thursday at 8am Pacific) |
…y#3166) * Update aws lambda spec to remove X-Ray Env propagation Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.
Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.
We also decided thatEventToCarrier
should be specified in the spec to improve cross language instrumentation consistency.I removed
EventToCarrier
from this PR to focus on the x-ray propagation. We can revisit in a separate PR.Fixes #3060