-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define conversion mapping from OTel Exponential Histograms to Prometheus Native Histograms. #3079
Conversation
@dashpole @Aneurysm9 @gouthamve please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I approve of the conversion, however I would like to see us attempt to rescale histograms as best we can to fit prometheus's current boundaries/limitations.
One of the goals of these histograms is to easily/efficiently rescale so we can balance performance + resolution. In that vein, I'd be a fan of something like:
If `Scale` is > 8 then exponential histogram data points SHOULD be downscaled to a scale accepted by prometheus (in range [-4,8]). Any data point unable to be rescaled to an acceptable range MUST be dropped.
This is a non-blocking request though.
We can reduce the scale if its greater than 8, but how would we change the scale if its less than -4? One option would be to introduce a |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…eus Native Histograms. (open-telemetry#3079)
Fixes #
#3078
Changes
Define conversion mapping from OTel Exponential Histograms to Prometheus Native Histograms. See, the implementation open-telemetry/opentelemetry-collector-contrib#17370
Related issues #
open-telemetry/opentelemetry-collector-contrib#16207
open-telemetry/opentelemetry-proto#440
Related OTEP(s) #
https://github.com/open-telemetry/oteps/blob/main/text/0149-exponential-histogram.md