Clarify prometheus unit conversions #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
changed the title
dashpole
force-pushed
the
prom_unit_clarification
branch
from
45db292 to
aaa1730
Compare
MrAlias
approved these changes
Jan 3, 2023
carlosalberto
approved these changes
Jan 4, 2023
|
Actually the description of the translation of Otel to Prometheus metrics is described here for the translator: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/translator/prometheus Side note: when will we enable the |
bertysentry
approved these changes
Jan 4, 2023
fstab
suggested changes
Jan 4, 2023
dashpole
force-pushed
the
prom_unit_clarification
branch
from
aaa1730 to
84628ab
Compare
jmacd
approved these changes
Jan 9, 2023
fstab
reviewed
Jan 10, 2023
dashpole
force-pushed
the
prom_unit_clarification
branch
from
8671314 to
676293c
Compare
dashpole
force-pushed
the
prom_unit_clarification
branch
from
676293c to
36723e0
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* clarify prometheus unit conversions * don't add unit if it already exists * remove recommendation to convert to base units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses confusion in this comment open-telemetry/opentelemetry-java#4390 (comment) by more completely describing the translation steps required for translating between prometheus unit conventions and opentelemetry unit conventions.
This draws on https://prometheus.io/docs/practices/naming/#base-units and https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#units-and-base-units. It matches the current implementation of the conversion in the collector: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/normalize_name.go except that it maintains the current recommendation to convert to base units in Prometheus exporters.
cc @jack-berg @psx95 @jmacd @gouthamve @open-telemetry/wg-prometheus @bertysentry