Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand pool.name in semantic conventions #3050

Merged
merged 24 commits into from
Mar 3, 2023

Conversation

haddasbronfman
Copy link
Member

according to the discussion here: #3038 I'm updating the pool.name attribute

according to the discussion here: open-telemetry#3038 I'm updating the `pool.name attribute`
@haddasbronfman haddasbronfman requested review from a team December 20, 2022 14:13
@arminru arminru linked an issue Dec 20, 2022 that may be closed by this pull request
@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory labels Dec 20, 2022
@arminru arminru requested a review from a team December 20, 2022 15:58
@haddasbronfman
Copy link
Member Author

Hi, Can someone do a CR please? (I already have one approval from Mateus)
@open-telemetry/specs-approvers or @open-telemetry/specs-metrics-approvers.
Thanks.

@haddasbronfman haddasbronfman requested review from tsloughter and arminru and removed request for arminru and tsloughter January 12, 2023 08:24
@haddasbronfman haddasbronfman removed the request for review from arminru January 15, 2023 07:34
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@haddasbronfman
Copy link
Member Author

@open-telemetry/specs-metrics-approvers Hi again, this PR was already stale and I don't want it to be close.
Can someone please review it?

haddasbronfman and others added 4 commits February 1, 2023 11:14
add commas to the example string

Co-authored-by: Armin Ruech <[email protected]>
Use db.connection_string as a fallback in case we don't have the name of the pool.
@carlosalberto
Copy link
Contributor

@open-telemetry/specs-approvers please review. There was a last cycle of feedback applied, so this should look better.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 27, 2023
@haddasbronfman
Copy link
Member Author

Hi,
it would be great to have approval for this issue from one of you please:
@jsuereth
@bogdandrutu
@jmacd
@tigrannajaryan
@arminru
@reyang

@github-actions github-actions bot removed the Stale label Feb 28, 2023
@carlosalberto
Copy link
Contributor

@haddasbronfman Once the markup is fixed (as @jsuereth mentioned), we are ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand the declaration of pool.name in the spec
6 participants