Split out Event API from Log API #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
I am going to give it this a quick approval since I think it is important to do the splitting and then work separately to refine the Log part and the Event part.
Particularly for the Log part I want us to address #2936 quickly since we are causing confusion with the way the spec is written now.
djaglowski
approved these changes
Nov 11, 2022
scheler
reviewed
Nov 11, 2022
scheler
approved these changes
Nov 11, 2022
reyang
approved these changes
Nov 11, 2022
|
@jack-berg please rebase. |
Aneurysm9
approved these changes
Nov 14, 2022
alanwest
approved these changes
Nov 14, 2022
3 tasks
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Nov 29, 2022
…on#2941 Signed-off-by: owent <[email protected]> Fix `-Werror=suggest-override` and style Signed-off-by: owent <[email protected]> Fix ostream_log_test Signed-off-by: owent <[email protected]> Fix ostream print_value for `AttributeValue` Signed-off-by: owent <[email protected]> New Recordable of logs Signed-off-by: owent <[email protected]> Restore .vscode/launch.json Signed-off-by: owent <[email protected]> Fix warning. Signed-off-by: owent <[email protected]> Fix warnings in maintainer mode and ETW exporter Signed-off-by: owent <[email protected]> Add CHANGELOG Signed-off-by: owent <[email protected]> Allow to move 'nostd::unique_ptr<T>' into `nostd::shared_ptr<T>` Signed-off-by: owent <[email protected]> Do not use `std/type_traits.h` any more. Maybe we should remove this file later. Signed-off-by: owent <[email protected]> Allow to add rvalue into `CircularBuffer` Signed-off-by: owent <[email protected]> Finish new `LogRecord` for exporters. Signed-off-by: owent <[email protected]> Finish unit tests in API and SDK. Exporters are still work in progress. Signed-off-by: owent <[email protected]> New `LogRecord` and `Recordable` implementations. Signed-off-by: WenTao Ou <[email protected]>
25 tasks
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2022
…on#2941 Signed-off-by: owent <[email protected]> Fix `-Werror=suggest-override` and style Signed-off-by: owent <[email protected]> Fix ostream_log_test Signed-off-by: owent <[email protected]> Fix ostream print_value for `AttributeValue` Signed-off-by: owent <[email protected]> New Recordable of logs Signed-off-by: owent <[email protected]> Restore .vscode/launch.json Signed-off-by: owent <[email protected]> Fix warning. Signed-off-by: owent <[email protected]> Fix warnings in maintainer mode and ETW exporter Signed-off-by: owent <[email protected]> Add CHANGELOG Signed-off-by: owent <[email protected]> Allow to move 'nostd::unique_ptr<T>' into `nostd::shared_ptr<T>` Signed-off-by: owent <[email protected]> Do not use `std/type_traits.h` any more. Maybe we should remove this file later. Signed-off-by: owent <[email protected]> Allow to add rvalue into `CircularBuffer` Signed-off-by: owent <[email protected]> Finish new `LogRecord` for exporters. Signed-off-by: owent <[email protected]> Finish unit tests in API and SDK. Exporters are still work in progress. Signed-off-by: owent <[email protected]> New `LogRecord` and `Recordable` implementations. Signed-off-by: WenTao Ou <[email protected]> Restore `nostd::unique_ptr` to `std::unique_ptr` in sdk and exporters. Signed-off-by: WenTao Ou <[email protected]> Fix feedback of comments and useless headers Signed-off-by: WenTao Ou <[email protected]> Optimize if branch in `ReadWriteLogRecord::GetResource` . Signed-off-by: owent <[email protected]>
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 12, 2022
…on#2941 Signed-off-by: owent <[email protected]> Fix `-Werror=suggest-override` and style Signed-off-by: owent <[email protected]> Fix ostream_log_test Signed-off-by: owent <[email protected]> Fix ostream print_value for `AttributeValue` Signed-off-by: owent <[email protected]> New Recordable of logs Signed-off-by: owent <[email protected]> Restore .vscode/launch.json Signed-off-by: owent <[email protected]> Fix warning. Signed-off-by: owent <[email protected]> Fix warnings in maintainer mode and ETW exporter Signed-off-by: owent <[email protected]> Add CHANGELOG Signed-off-by: owent <[email protected]> Allow to move 'nostd::unique_ptr<T>' into `nostd::shared_ptr<T>` Signed-off-by: owent <[email protected]> Do not use `std/type_traits.h` any more. Maybe we should remove this file later. Signed-off-by: owent <[email protected]> Allow to add rvalue into `CircularBuffer` Signed-off-by: owent <[email protected]> Finish new `LogRecord` for exporters. Signed-off-by: owent <[email protected]> Finish unit tests in API and SDK. Exporters are still work in progress. Signed-off-by: owent <[email protected]> New `LogRecord` and `Recordable` implementations. Signed-off-by: WenTao Ou <[email protected]> Restore `nostd::unique_ptr` to `std::unique_ptr` in sdk and exporters. Signed-off-by: WenTao Ou <[email protected]> Fix feedback of comments and useless headers Signed-off-by: WenTao Ou <[email protected]> Optimize if branch in `ReadWriteLogRecord::GetResource` . Signed-off-by: owent <[email protected]>
lalitb
pushed a commit
to open-telemetry/opentelemetry-cpp
that referenced
this pull request
Dec 13, 2022
4 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Resolves open-telemetry#2917. Depends on open-telemetry#2940.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2917.
Depends on #2940.