Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more semantic convention attributes of Apache RocketMQ #2881

Conversation

aaron-ai
Copy link
Member

Fixes #2880

@aaron-ai aaron-ai requested review from a team October 17, 2022 03:42
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch from 13f2d58 to bbd5454 Compare October 17, 2022 03:47
@aaron-ai aaron-ai changed the title Add "messaging.rocketmq.messsage_group" convention Add more semantics convention attributes of Apache RocketMQ Oct 17, 2022
@aaron-ai aaron-ai changed the title Add more semantics convention attributes of Apache RocketMQ Add more semantic convention attributes of Apache RocketMQ Oct 17, 2022
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch 7 times, most recently from 6d4819a to 23d4406 Compare October 23, 2022 03:04
@aaron-ai
Copy link
Member Author

aaron-ai commented Oct 24, 2022

@arminru @jsuereth @tigrannajaryan @carlosalberto Could you help to review it?

@carlosalberto
Copy link
Contributor

It would be good to get a review from the messaging working group.

@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch from 23d4406 to 3721973 Compare October 25, 2022 01:44
@aaron-ai
Copy link
Member Author

It seems that markdown-link-check is failed, which is not related to this pull request. re-run is required.

@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch from 3721973 to 8f7d9d3 Compare October 26, 2022 04:51
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch from 8f7d9d3 to 704c641 Compare November 3, 2022 01:21
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_message_group branch from 704c641 to bfac710 Compare November 4, 2022 07:01
@carlosalberto
Copy link
Contributor

Maybe @pyohannes @joaopgrassi can review this one as well? (or anybody from the messaging wg ;) )

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more semantic convention attributes of Apache RocketMQ
5 participants