Change to messaging.kafka.max.lag from UpDownCounter to Gauge (and rename it) #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
Sep 28, 2022
reyang
approved these changes
Sep 28, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes to
messaging.kafka.max.lagfrom UpDownCounter to Gauge, since doesn't make sense to aggregate maxes.Also, renames
messaging.kafka.max.lagtomessaging.kafka.lag_max, to be consistent withmessaging.kafka.consumer.lag_sum.Schema translation for the rename is not included since also changing its type, so seems better(?) to treat it as a breaking change with no schema translation support.