Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log readme to reflect addition of API #2800

Merged
merged 15 commits into from
Oct 7, 2022

Conversation

jack-berg
Copy link
Member

Resolves #2799.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In application-api-sdk.png can we add one more arrow calling from "Auto and Manual Instrumentation" directly to Log API and probably annotate it with "events", since this is now a valid approach.

specification/logs/README.md Outdated Show resolved Hide resolved
specification/logs/README.md Outdated Show resolved Hide resolved
@reyang reyang added the spec:logs Related to the specification/logs directory label Sep 30, 2022
@tigrannajaryan
Copy link
Member

We have approvals so I am going to merge this, bit I think we need more clarifications around events vs logs since there is still confusion around what they are, see e.g. open-telemetry/opentelemetry-collector-contrib#14474

I will see if I can create a PR that addresses the remaining questions.

@tigrannajaryan tigrannajaryan merged commit 05650d3 into open-telemetry:main Oct 7, 2022
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Resolves open-telemetry#2799.

* Indicate that instrumentation can produce events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct inconsistencies in log README.md
7 participants