Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default buckets for Explicit Bucket Histogram #2770

Merged
merged 11 commits into from
Sep 21, 2022
Merged

Change the default buckets for Explicit Bucket Histogram #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
05c954f
Change the default buckets for Explicit Bucket Histogram
reyang Sep 2, 2022
8202ef0
changelog
reyang Sep 2, 2022
4bded9d
fix typo
reyang Sep 2, 2022
8bf35e5
Merge branch 'main' into reyang/histogram-buckets
reyang Sep 9, 2022
691fa0e
Merge branch 'main' into reyang/histogram-buckets
reyang Sep 15, 2022
216b213
Merge branch 'main' into reyang/histogram-buckets
reyang Sep 15, 2022
6aee3e4
Merge branch 'main' into reyang/histogram-buckets
reyang Sep 16, 2022
43839ec
Merge branch 'main' into reyang/histogram-buckets
bogdandrutu Sep 20, 2022
beb444a
Merge branch 'main' into reyang/histogram-buckets
reyang Sep 20, 2022
faa2e32
making default a SHOULD
reyang Sep 20, 2022
175b4b2
move changelog to unreleased section
reyang Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ release.

### Metrics

- Changed the default buckets for Explicit Bucket Histogram to better match the
official Prometheus clients.
([#2770](https://github.com/open-telemetry/opentelemetry-specification/pull/2770)).

### Logs

### Resource
Expand Down
2 changes: 1 addition & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ This Aggregation honors the following configuration parameters:

| Key | Value | Default Value | Description |
| --- | --- | --- | --- |
| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 1000 ] | Array of increasing values representing explicit bucket boundary values.<br><br>The Default Value represents the following buckets:<br>(-&infin;, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 1000.0], (1000.0, +&infin;) |
| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000 ] | Array of increasing values representing explicit bucket boundary values.<br><br>The Default Value represents the following buckets (heavily influenced by the default buckets of Prometheus clients, e.g. [Java](https://github.com/prometheus/client_java/blob/6730f3e32199d6bf0e963b306ff69ef08ac5b178/simpleclient/src/main/java/io/prometheus/client/Histogram.java#L88) and [Go](https://github.com/prometheus/client_golang/blob/83d56b1144a0c2eb10d399e7abbae3333bebc463/prometheus/histogram.go#L68)):<br>(-&infin;, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 750.0], (750.0, 1000.0], (1000.0, 2500.0], (2500.0, 5000.0], (5000.0, 7500.0], (7500.0, 10000.0], (10000.0, +&infin;). SDKs SHOULD use the default value when boundaries are not explicitly provided, unless they have good reasons to use something different (e.g. for backward compatibility reasons in a stable SDK release). |
| RecordMinMax | true, false | true | Whether to record min and max. |

Explicit buckets are stated in terms of their upper boundary. Buckets
Expand Down