Prometheus compatibility: use target_info metric instead of "target" info MF #2701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There was some confusion around the use of
"target" info MetricFamily
vstarget_info Metric
, which even caused me to incorrectly implement the feature in the collector.In OpenMetrics, MetricFamily refers to the group of multiple metric datapoints which share the same name. For example, a histogram MetricFamily named
scrape_duration_seconds
contains Metrics namedscrape_duration_seconds_sum
andscrape_duration_seconds_count
, etc. The suffixes appended to the Metric(s) within a MetricFamily depend on the metric type. For info-typed metrics, the suffix is always_info
. Thus, thetarget
info-typed MetricFamily has Metric(s) namedtarget_info
:In Prometheus (not OpenMetrics), "info" is a convention, rather than a type, and are thus represented with a gauge, which has no type suffix. Thus, in prometheus, both the MetricFamily and the Metric(s) are named
target_info
.Changes
Since the common portion between OM and Prom is the metric name, rather than the metric family, update references in the spec for
"target" info MetricFamily
totarget_info metric
.cc @jmacd