-
Notifications
You must be signed in to change notification settings - Fork 911
Add 'type' to all groups #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'type' to all groups #2693
Conversation
@CleanCut can you show in the PR description what was the warning? Ideally include before and after output to make it clear what is improved. |
@tigrannajaryan ✅ Added. Note: There's no output afterwards (that's the whole point). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense to me, I don't see any negative impact of this.
I also ask in future that instead of a screenshot, you add just the raw text since it makes it easier to grep for logs / errors in the code. |
Sure thing. ✅ Adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on generating code files from the conventions for .NET and I started noticing these warnings as well. Thanks for addressing them!
No problem! They've been bothering us for awhile. |
Adds a
type
to every group to resolve the build tools' unsilenceable warning mentioned in open-telemetry/build-tools#109Changes
I added a
type
field to every group that was missing one. Since I didn't know what value to put, I guessedresource
for the ones in theresource
subdirectory, and left all the rest tospan
since that's what they were defaulting to.This silences the warnings and results in zero differences in generated code in my testing.
Before this change (without open-telemetry/build-tools#109 (comment))
Also before this change (with open-telemetry/build-tools#109 (comment))
After this change: