Allow LogProcessor to mutate log records #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jul 25, 2022
reyang
approved these changes
Jul 25, 2022
tigrannajaryan
approved these changes
Jul 27, 2022
|
@open-telemetry/specs-logs-approvers please take a look! |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Pinging @open-telemetry/specs-logs-approvers. Please take a look! Otel java has already implemented and published this change here. |
djaglowski
approved these changes
Aug 20, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Resolves open-telemetry#2647. The simplest possible fix would have been to simply change `LogProcessor#emit` to accept `LogRecord` instead of `LogData`, but I took the opportunity to add some additional detail to make logs more consistent with spans where possible. Changes include: - Add TOC - Rename LogProcessor#emit to LogProcessor#onEmit. This is more consistent with spans (SpanProcessor#onStart, SpanProcessor#onEnd), and avoids confusion by being different than LogEmitter#emit. - Define LogRecord interface, accepted by LogEmitter#emit - Define Read/write LogRecord interface, accepted by LogProcessor#onEmit - Define Readable LogRecord interface, accepted in batches by LogExporter#export - Add LogExporter#forceFlush method (stubbed out for now) for consistency with SpanExporter#forceFlush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2647.
The simplest possible fix would have been to simply change
LogProcessor#emitto acceptLogRecordinstead ofLogData, but I took the opportunity to add some additional detail to make logs more consistent with spans where possible.Changes include: