-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK spec to the latest W3C Baggage spec version #2670
Conversation
I wasn't sure if this could be considered a significant change, and so I didn't update the |
A few comments on my approval:
|
Thanks @jsuereth!
I pushed a new commit with a CHANGELOG entry. I wasn't sure where to add it, so I placed it under the
I'm not sure who the maintainers are, so I will open an issue on each SDK repo and link back to this PR to help maintainers keep track of the changes necessary for their own project. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…y#2670) * Update SDK spec to the latest W3C Baggage spec version * Add changelog entry for open-telemetry#2670 * Fix location of open-telemetry#2670 in the changelog Co-authored-by: Yuri Shkuro <[email protected]>
Fixes #2639
Changes
Update the version of the W3C Baggage spec used by the Resource SDK for the
OTEL_RESOURCE_ATTRIBUTES
environment variable so it matches the version used by the baggage propagation API.The key difference is the requirement to percent-encode characters outside the
baggage-octate
range, and so this is now highlighted in the SDK spec.Full diff between the latest version and the version used before:
https://github.com/w3c/baggage/compare/fdc7a5c4f4a31ba2a36717541055e551c2b032e4..main#diff-f65e951e116caf027fff48025b09977ad3539456579743d5c8018b9313484229