Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SpanExporter#ForceFlush is required #2654

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Clarify SpanExporter#ForceFlush is required #2654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11b98d9
Clarify SpanExporter#ForceFlush is required
dyladan Jul 8, 2022
30e9d93
Use normative MUST
dyladan Jul 11, 2022
701a7b5
Merge branch 'main' into span-exporter-forceflush
dyladan Jul 12, 2022
68d0ef4
Changelog
dyladan Jul 12, 2022
f83bf47
Merge branch 'main' into span-exporter-forceflush
arminru Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ release.
- Clarify the return of `Export(batch)` in the Batch Span Processor and exporter
concurrency ([#2452](https://github.com/open-telemetry/opentelemetry-specification/pull/2452))
- Clarify that Context should not be mutable when setting a span ([#2637](https://github.com/open-telemetry/opentelemetry-specification/pull/2637))
- Clarify that `ForceFlush` is a required method on `SpanExporter` interface.
([#2654](https://github.com/open-telemetry/opentelemetry-specification/pull/2654)).

### Metrics

Expand Down
4 changes: 2 additions & 2 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,8 @@ primarily a simple telemetry data encoder and transmitter.

### Interface Definition
dyladan marked this conversation as resolved.
Show resolved Hide resolved

The exporter must support two functions: **Export** and **Shutdown**. In
strongly typed languages typically there will be 2 separate `Exporter`
The exporter MUST support three functions: **Export**, **Shutdown**, and **ForceFlush**.
In strongly typed languages typically there will be 2 separate `Exporter`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, maybe we can just remove this sentence? It mentioned metrics in a tracing spec (also it might be inaccurate because LogExporter does exist https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/logging-library-sdk.md#logexporter).

interfaces, one that accepts spans (SpanExporter) and one that accepts metrics
(MetricsExporter).

Expand Down