-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify how to obtain a Ruby thread's id #2508
Specify how to obtain a Ruby thread's id #2508
Conversation
Update the span-general.md#source-code-attributes table for obtaining thread ids and names across languages to explain how to obtain a thread's id for Ruby.
|
Is there always only one unique Ruby object per logical Thread? Otherwise I think this may have confusing results. |
Hi @Oberon00. The table row in question already had a value for the current thread's name. There is a That instance of the |
@open-telemetry/ruby-maintainers @open-telemetry/ruby-approvers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello from @open-telemetry/ruby-approvers 👋
Since the semantic conventions explicitly require that thread.id
be the Current "managed" thread ID (as opposed to OS thread ID).
- this would be the right way to go about it. 👍
Update the span-general.md#source-code-attributes table for obtaining
thread ids and names across languages to explain how to obtain a
thread's id for Ruby.