-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry RESOURCE_EXHAUSTED only if the server can recover #2480
Retry RESOURCE_EXHAUSTED only if the server can recover #2480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a CHANGELOG enty.
I believe this is an allowed change since it can be considered a specification bug that it did not take into account the RESOURCE_EXHAUSTED can have more than one meaning and needs a more detailed description in the spec.
@svrakitin please resolve the conflicts. |
Recommend clients to retry on
RESOURCE_EXHAUSTED
only if the server can recover. The server can indicate this by signaling backpressure (by includingRetryInfo
into response).See: open-telemetry/opentelemetry-collector#5147 (comment)
I might need help with exact wording here to stay consistent with the rest of the spec.