Add documentation requirement for adding attributes at span creation #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Feb 25, 2022
Oberon00
approved these changes
Feb 26, 2022
cijothomas
approved these changes
Feb 28, 2022
arminru
added
area:api
arminru
approved these changes
Mar 1, 2022
Co-authored-by: Armin Ruech <[email protected]>
cijothomas
approved these changes
Mar 1, 2022
yurishkuro
approved these changes
Mar 1, 2022
arminru
approved these changes
Mar 2, 2022
Co-authored-by: Armin Ruech <[email protected]>
bogdandrutu
approved these changes
Mar 3, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#2383) * Add documentation requirement for adding attributes at span creation * Adding changelog entry * Update specification/trace/api.md Co-authored-by: Armin Ruech <[email protected]> * Add documentation requirement to spec compliance matrix * Update spec-compliance-matrix.md Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is prompted by @MrAlias's request in #2278 (comment).
The information that attributes should preferably be added at span creation rather than later by calling
SetAttributeis relevant to users of the API and should be conveyed to them.