-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft logging library SDK specification #2328
Merged
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
tigrannajaryan:add-loglib-sdk
Feb 17, 2022
Merged
Add draft logging library SDK specification #2328
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
tigrannajaryan:add-loglib-sdk
Feb 17, 2022
+211
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
add-loglib-sdk
branch
from
February 9, 2022 16:01
90a9530
to
ad2ca4a
Compare
yurishkuro
reviewed
Feb 9, 2022
jack-berg
reviewed
Feb 9, 2022
jack-berg
approved these changes
Feb 10, 2022
jack-berg
reviewed
Feb 10, 2022
jack-berg
reviewed
Feb 10, 2022
reyang
reviewed
Feb 12, 2022
reyang
reviewed
Feb 12, 2022
reyang
reviewed
Feb 12, 2022
reyang
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor suggestions.
@open-telemetry/specs-logs-approvers please review. |
djaglowski
approved these changes
Feb 14, 2022
kumoroku
approved these changes
Feb 17, 2022
tigrannajaryan
force-pushed
the
add-loglib-sdk
branch
from
February 17, 2022 16:13
155301a
to
1e83bfc
Compare
This is the first cut from the [OTEP0150](https://github.com/open-telemetry/oteps/blob/main/text/logs/0150-logging-library-sdk.md) This a draft that requires cleanup and clarifications that will be done in follow-up PR. This PR primarily copies the OTEP0150 content, minus sections which are typically only present in OTEPS (Motivaiton, Alternates, Future Possibilities, etc).
tigrannajaryan
force-pushed
the
add-loglib-sdk
branch
from
February 17, 2022 18:41
1e83bfc
to
673421d
Compare
We have enough approvals. I think the draft is good to merge. It is not the final form anyway, we will need to work on this doc. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This is the first cut from the [OTEP0150](https://github.com/open-telemetry/oteps/blob/main/text/logs/0150-logging-library-sdk.md) This a draft that requires cleanup and clarifications that will be done in follow-up PR. This PR primarily copies the OTEP0150 content, minus sections which are typically only present in OTEPS (Motivaiton, Alternates, Future Possibilities, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first cut from the OTEP0150
This a draft that requires cleanup and clarifications that will be done in follow-up PR.
This PR primarily copies the OTEP0150 content, minus sections which are typically
only present in OTEPS (Motivation, Alternates, Future Possibilities, etc).