Support Bagagge-only propagation in the OpenTracing Shim. #2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an item from #2147
Although many OpenTracing tracers do not support baggage propagation amidst missing/invalid
SpanContext
, this is something (at least) Jaeger clients expect.Overall, the changes to properly support this are:
Baggage
, even amidst missing/invalidSpanContext
, in order to support the vanilla OT propagation case:activeSpan()
MUST includeBaggage
handling, in order to support OTel/OT explicit propagation:startSpan()
MUST consume any activeBaggage
, in order to support OTel/OT implicit propagation:See the prototype for Java: https://github.com/carlosalberto/opentelemetry-java/compare/otshim-spanshim-lock...carlosalberto:otshim-baggage-only-support?expand=1