Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about MetricExporter naming #2286

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Add notes about MetricExporter naming #2286

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
799a915
Add notes about MetricExporter naming
legendecas Jan 24, 2022
88e53eb
Merge branch 'main' into metric-exporter
carlosalberto Jan 30, 2022
589c7c4
Merge branch 'main' into metric-exporter
legendecas Feb 9, 2022
e4775a1
Merge branch 'main' into metric-exporter
legendecas Feb 10, 2022
761d32b
Merge branch 'main' into metric-exporter
tigrannajaryan Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,9 @@ Implementors MAY choose the best idiomatic design for their language. For
example, they could generalize the [Push Metric Exporter
interface](#push-metric-exporter) design and use that for consistency, they
could model the pull exporter as [MetricReader](#metricreader), or they could
design a completely different pull exporter interface.
design a completely different pull exporter interface. If the pull exporter is
modeled as MetricReader, implementors MAY name the MetricExporter interface as
PushMetricExporter to prevent naming confusion.

The following diagram gives some examples on how `Pull Metric Exporter` can be
modeled to interact with other components in the SDK:
Expand Down