Make multi-instrument idioms for async callbacks possible #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we also need to loosen the requirement that APIs produce an error when multiple instruments are registered with the same name. Does that make sense to do in this PR or in a separate one? |
|
@jack-berg this PR definitely depends on #2270. |
Aneurysm9
reviewed
Jan 21, 2022
jack-berg
approved these changes
Feb 1, 2022
|
It seems natural that if multiple callbacks allowed, that there should be some way of unregister / cancel / stop callbacks #2232. But I think that can be solved separately. |
MrAlias
approved these changes
Feb 1, 2022
anuraaga
approved these changes
Feb 1, 2022
|
Reviewers, as noted in #2226 (comment) I am closing this PR. This work will be integrated into #2270 following the discussion in #2226. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2280
Changes
This changes slightly the requirement for how instruments are associated with callbacks. Whereas before the spec required one instrument per callback, this would allow multiple instruments. A motivating example is given in #2280.
Related issues #2270 #2249