Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extra dimensions to extra attributes #2162

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Rename extra dimensions to extra attributes #2162

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecd0a2b
Rename extra dimensions to extra attributes
anuraaga Nov 24, 2021
8a5ba50
Moar
anuraaga Nov 25, 2021
71c2728
Merge branch 'main' into dimension-to-attribute
reyang Nov 30, 2021
87a75db
Merge branch 'main' into dimension-to-attribute
jmacd Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ are the inputs:
not in the list will be ignored. If not provided, all the attribute keys
will be used by default (TODO: once the Hint API is available, the default
behavior should respect the Hint if it is available).
* The `extra dimensions` which come from Baggage/Context (optional). If not
provided, no extra dimension will be used. Please note that this only
* The `extra attributes` which come from Baggage/Context (optional). If not
reyang marked this conversation as resolved.
Show resolved Hide resolved
provided, no extra attributes will be used. Please note that this only
applies to [synchronous Instruments](./api.md#synchronous-instrument).
* The `aggregation` (optional) to be used. If not provided, the SDK SHOULD
apply a [default aggregation](#default-aggregation). If the aggregation
Expand Down