Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some would be -> MUST in metrics spec. #2161

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Change some would be -> MUST in metrics spec. #2161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cab400
Change some would be -> MUST in metrics spec.
anuraaga Nov 24, 2021
b008ebd
Merge branch 'main' into would-be-must
jmacd Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ are the inputs:
refer to [Error handling in OpenTelemetry](../error-handling.md) for the
general guidance.
* The `name` of the View (optional). If not provided, the Instrument `name`
would be used by default. This will be used as the name of the [metrics
MUST be used by default. This will be used as the name of the [metrics
stream](./datamodel.md#events--data-stream--timeseries).
* The configuration for the resulting [metrics
stream](./datamodel.md#events--data-stream--timeseries):
* The `description`. If not provided, the Instrument `description` would be
* The `description`. If not provided, the Instrument `description` MUST be
used by default.
* A list of `attribute keys` (optional). If provided, the attributes that are
not in the list will be ignored. If not provided, all the attribute keys
Expand Down