-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-op StartSpan: always return the parent #2121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:api
Cross language API specification issue
spec:trace
Related to the specification/trace directory
labels
Nov 16, 2021
bogdandrutu
reviewed
Nov 16, 2021
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
bogdandrutu
approved these changes
Nov 29, 2021
iNikem
approved these changes
Nov 30, 2021
jmacd
approved these changes
Nov 30, 2021
Oberon00
requested changes
Dec 1, 2021
jmacd
approved these changes
Dec 1, 2021
Co-authored-by: Christian Neumüller <[email protected]>
Oberon00
approved these changes
Dec 2, 2021
carlosalberto
approved these changes
Dec 2, 2021
Hey, we forgot to add a CHANGELOG entry! @tsloughter think you could cook one? |
@carlosalberto woops, yup, will open a PR in a minute. |
tsloughter
added a commit
to tsloughter/opentelemetry-specification
that referenced
this pull request
Dec 3, 2021
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Dec 3, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* no-op StartSpan: always return the parent * Update specification/trace/api.md Co-authored-by: Christian Neumüller <[email protected]> Co-authored-by: Christian Neumüller <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:api
Cross language API specification issue
spec:trace
Related to the specification/trace directory
Stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change makes it so no span id generation is required in the API's no-op tracer. My understanding from the discussion back when this part was added to the spec the implementation is supposed to create a new span id in the no-op tracer if the parent is a recording span -- while saying this is almost never the case it still would require it to be possible.
This is what we had implemented in the Erlang API:
After implementing configurable IdGenerators which required moving the id generators to the SDK, https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#id-generators, I realized the above code could no longer be possible and would not make sense even if it were.
Go and Java both always return the parent or the empty non-recording span, and maybe others. If this is the case for those two and others then this change is an attempt to bring the spec inline with existing implementations. So I think that makes it a non-breaking change :)