Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset and empty environment variables are equivalent #2045

Merged
merged 16 commits into from
Nov 4, 2021
+10 −1
Merged

Unset and empty environment variables are equivalent #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
745d500
Handling env var's empty value
pellared Oct 20, 2021
dd5d00d
Update sdk-environment-variables.md
pellared Oct 21, 2021
ce2381c
Update sdk-environment-variables.md
pellared Oct 21, 2021
83d6948
Update sdk-environment-variables.md
pellared Oct 21, 2021
cdaf5ac
Update sdk-environment-variables.md
pellared Oct 21, 2021
a83223b
Update specification/sdk-environment-variables.md
pellared Oct 22, 2021
0974a86
Update sdk-environment-variables.md
pellared Oct 22, 2021
d88b4ca
Update CHANGELOG.md
pellared Oct 22, 2021
c87bc4b
Fix lint
pellared Oct 22, 2021
57b8e6e
Merge branch 'main' into patch-1
pellared Oct 22, 2021
e73ecd2
Merge branch 'main' into patch-1
pellared Oct 22, 2021
3be87c4
Remove - for empty value as default
pellared Oct 26, 2021
5134e1d
Merge branch 'main' into patch-1
pellared Oct 26, 2021
66b4b52
Update sdk-environment-variables.md
pellared Nov 4, 2021
9fdf24b
Merge branch 'main' into patch-1
pellared Nov 4, 2021
10a3597
Merge branch 'main' into patch-1
carlosalberto Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ release.

### SDK Configuration

- Unset and empty environment variables are equivalent.
([#2045](https://github.com/open-telemetry/opentelemetry-specification/pull/2045))

### Telemetry Schemas

Added telemetry schemas documents to the specification ([#2008](https://github.com/open-telemetry/opentelemetry-specification/pull/2008))
Expand Down
8 changes: 7 additions & 1 deletion specification/sdk-environment-variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

The goal of this specification is to unify the environment variable names between different OpenTelemetry SDK implementations. SDKs MAY choose to allow configuration via the environment variables in this specification, but are not required to. If they do, they SHOULD use the names listed in this document.

## Parsing empty value

**Status**: [Stable](document-status.md)

The SDK MUST interpret an empty value of an environment variable the same way as when the variable is unset.

## Special configuration types

**Status**: [Stable](document-status.md)
Expand Down Expand Up @@ -133,7 +139,7 @@ See [Jaeger Agent](https://www.jaegertracing.io/docs/latest/deployment/#agent) d
| Name | Description | Default |
| ----------------------------- | -------------------------- | ------------------------------------------------------------------------------------------------------------ |
| OTEL_EXPORTER_ZIPKIN_ENDPOINT | Endpoint for Zipkin traces | <!-- markdown-link-check-disable --> "http://localhost:9411/api/v2/spans"<!-- markdown-link-check-enable --> |
| OTEL_EXPORTER_ZIPKIN_TIMEOUT | Maximum time the Zipkin exporter will wait for each batch export | 10s |
| OTEL_EXPORTER_ZIPKIN_TIMEOUT | Maximum time the Zipkin exporter will wait for each batch export | 10s |

Addtionally, the following environment variables are reserved for future
usage in Zipkin Exporter configuration:
Expand Down