Add telemetry schemas to the specification #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
add-schemas
branch
5 times, most recently
from
afdfaf9 to
ef620a7
Compare
This merges the remaining bits of OTEP0152 to the specification and links to already existing schema-related sections in the API. The documents are marked as "Experimental", however I would like to promote file_format_v1.0.0.md to Stable as soon as possible since we already have published such files. Related to open-telemetry/oteps#152
tigrannajaryan
force-pushed
the
add-schemas
branch
from
ef620a7 to
53cf697
Compare
jmacd
approved these changes
Oct 13, 2021
|
@open-telemetry/specs-approvers please review. |
|
@open-telemetry/specs-approvers this needs a review. It is merging of an already approved OTEP. |
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Oct 18, 2021
We want to capture if OTLP exporters implement OTLP changes required by OTEP0152 (https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md) Continuation of open-telemetry#2008
pyohannes
reviewed
Oct 18, 2021
apply_to_spans section was missing although it is implied to be present in the description of how span changes section is supposed to work. This fixes the omission by adding apply_to_spans section. This is not a new feature, there is no semantics change, just fixing a bug in file format description.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
Oct 18, 2021
This bug was uncovered during spec review here: open-telemetry/opentelemetry-specification#2008 (comment) apply_to_spans section was missing although it is implied to be present in the description of how span changes section is supposed to work. This fixes the omission by adding apply_to_spans section. This is not a new feature, just fixing a bug in file format description and in the corresponding implementation.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
Oct 18, 2021
This bug was uncovered during spec review here: open-telemetry/opentelemetry-specification#2008 (comment) apply_to_spans section was missing although it is implied to be present in the description of how span changes section is supposed to work. This fixes the omission by adding apply_to_spans section. This is not a new feature, just fixing a bug in file format description and in the corresponding implementation.
pyohannes
approved these changes
Oct 19, 2021
carlosalberto
approved these changes
Oct 19, 2021
|
I am going to keep this open for a bit more since there was a small (but functional) change / bug fix to the OTEP text. I want to make sure there is awareness of the change (does not affect existing published schemas in any way, we don't break anything). |
tigrannajaryan
added a commit
that referenced
this pull request
Oct 20, 2021
We want to capture if OTLP exporters implement OTLP changes required by OTEP0152 (https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md) Continuation of #2008
|
I need a couple more approvals since it is a big chunk of text (although already approved OTEP). |
anuraaga
approved these changes
Oct 22, 2021
|
@open-telemetry/specs-approvers Please review. |
zenmoto
approved these changes
Oct 22, 2021
|
Merging, I think we have enough approvals now. |
Aneurysm9
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Oct 25, 2021
This bug was uncovered during spec review here: open-telemetry/opentelemetry-specification#2008 (comment) apply_to_spans section was missing although it is implied to be present in the description of how span changes section is supposed to work. This fixes the omission by adding apply_to_spans section. This is not a new feature, just fixing a bug in file format description and in the corresponding implementation. Co-authored-by: Anthony Mirabella <[email protected]>
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
This bug was uncovered during spec review here: open-telemetry/opentelemetry-specification#2008 (comment) apply_to_spans section was missing although it is implied to be present in the description of how span changes section is supposed to work. This fixes the omission by adding apply_to_spans section. This is not a new feature, just fixing a bug in file format description and in the corresponding implementation. Co-authored-by: Anthony Mirabella <[email protected]>
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
We want to capture if OTLP exporters implement OTLP changes required by OTEP0152 (https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md) Continuation of open-telemetry/opentelemetry-specification#2008
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Add telemetry schemas to the specification This merges the remaining bits of OTEP0152 to the specification and links to already existing schema-related sections in the API. The documents are marked as "Experimental", however I would like to promote file_format_v1.0.0.md to Stable as soon as possible since we already have published such files. Related to open-telemetry/oteps#152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add telemetry schemas to the specification
This merges the remaining bits of OTEP0152 to the specification
and links to already existing schema-related sections in the API.
The documents are marked as "Experimental", however I would like
to promote file_format_v1.0.0.md to Stable as soon as possible since we
already have published such files.
Related to open-telemetry/oteps#152