Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify metrics SDK limits handling #2007

Merged
merged 11 commits into from
Oct 15, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 11, 2021

Fixes #1936.

@reyang reyang requested review from a team October 11, 2021 17:09
@reyang reyang added the area:sdk Related to the SDK label Oct 11, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Oct 11, 2021
@reyang reyang added the spec:metrics Related to the specification/metrics directory label Oct 11, 2021
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, pending Armin's comments being resolved.

specification/metrics/sdk.md Show resolved Hide resolved
@jmacd jmacd enabled auto-merge (squash) October 15, 2021 17:27
@jmacd jmacd merged commit 512c344 into open-telemetry:main Oct 15, 2021
@reyang reyang deleted the reyang/metrics-sdk-limits branch October 18, 2021 18:59
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Clarify metrics SDK limits handling

* fix link

* Update specification/metrics/sdk.md

Co-authored-by: Armin Ruech <[email protected]>

* Update specification/metrics/sdk.md

Co-authored-by: Armin Ruech <[email protected]>

* Apply suggestions from code review

Co-authored-by: Armin Ruech <[email protected]>

* lowercase

* update changelog

Co-authored-by: Armin Ruech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call out the behavior of Inf and NaN values for the metrics API
5 participants