Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics supplementary guideline for instrumentation authors #1981

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Add metrics supplementary guideline for instrumentation authors #1981

merged 7 commits into from
Oct 4, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 30, 2021

Fixes #1632.

@reyang reyang requested review from a team September 30, 2021 18:29
jsuereth
jsuereth approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the additions! Minor english/structure nits.

specification/metrics/supplementary-guidelines.md Outdated Show resolved Hide resolved
specification/metrics/supplementary-guidelines.md Show resolved Hide resolved
@reyang reyang added area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory labels Sep 30, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Sep 30, 2021
jkwatson
jkwatson approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thanks!

@jsuereth jsuereth enabled auto-merge (squash) October 4, 2021 13:37
@jsuereth jsuereth merged commit 9ceb9fa into open-telemetry:main Oct 4, 2021
@reyang reyang deleted the reyang/metrics-guidance branch October 4, 2021 17:32
@reyang reyang restored the reyang/metrics-guidance branch October 4, 2021 17:32
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang @jkwatson @jsuereth
Add metrics supplementary guideline for instrumentation authors (open…
9e1f8b2 
…-telemetry#1981)

* Add metrics supplementary guideline for instrumentation authors

* address the review comments

* Apply suggestions from code review

Co-authored-by: John Watson <[email protected]>

* Update specification/metrics/supplementary-guidelines.md

Co-authored-by: John Watson <[email protected]>

* rewrap

Co-authored-by: John Watson <[email protected]>
Co-authored-by: Josh Suereth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@jkwatson jkwatson jkwatson approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.

Document "which instrument to pick" in the metrics README
5 participants
@reyang @jsuereth @jkwatson @jmacd @carlosalberto