Consistently format enums, fix non-identifier IDs. #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:semantic-conventions
Oberon00
commented
Aug 11, 2021
| @@ -22,6 +22,10 @@ release. | |||
|
|
|||
| ### Semantic Conventions | |||
|
|
|||
| - BREAKING: Change enum member IDs to lowercase without spaces, not starting with numbers. | |||
There was a problem hiding this comment.
This is a breaking change, but to an experimental part and only in recently added enum members.
carlosalberto
approved these changes
Aug 11, 2021
arminru
approved these changes
Aug 12, 2021
|
@Oberon00 Regarding the breaking portion, is it enough to let Maintainers know next Monday, or should we do something else? |
|
I think that would be enough, as actual data breakage is only in stuff that is new and experimental. But probably I'm the wrong person to ask that question to. 😃 |
|
@tigrannajaryan maybe you have something to say? |
|
@Oberon00 Please update the CHANGELOG so we can merge ;) |
carlosalberto
pushed a commit
that referenced
this pull request
Aug 25, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1519 (again) and also fixes some
ids containing spaces (Alibaba Cloud->alibaba_cloud) or starting with numbers (1xRTT->csma2000_1xrtt) which tripped up code generators (open-telemetry/build-tools#59).Changes
Changes enum IDs to be lowercase.
Also changes values and briefs of
net.host.connection.subtypeandrpc.grpc.status_codeto match the IDs. http.flavor is left unchanged since it is already quite old (but http.flavor should probably be refactored anyway separately).