Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics exporters spec files #1837

Merged
merged 6 commits into from
Aug 3, 2021
Merged

Add metrics exporters spec files #1837

merged 6 commits into from
Aug 3, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 29, 2021

Changes

  • Updated the library guideline to clarify exporter for logs/metrics/traces.
  • Added skeleton files for metrics exporters.

@reyang reyang requested review from a team July 29, 2021 05:46
@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Jul 29, 2021
jsuereth
jsuereth approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to see links to these from the SDK specification, but I see that's not true for Trace.

specification/metrics/sdk_exporters/console.md Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit b76e16f into open-telemetry:main Aug 3, 2021
@reyang reyang mentioned this pull request Aug 12, 2021
Merged
@reyang reyang deleted the reyang/metrics-exporter-skeleton branch October 4, 2021 17:32
@pirgeo pirgeo mentioned this pull request Nov 30, 2021
Closed
6 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang
Add metrics exporters spec files (open-telemetry#1837)
03913a1 
* Updated the library guideline to clarify exporter for logs/metrics/traces.
* Added skeleton files for metrics exporters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirgeo pirgeo pirgeo approved these changes

@arminru arminru arminru approved these changes

@cijothomas cijothomas cijothomas approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@jmacd jmacd jmacd approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@jsuereth jsuereth jsuereth approved these changes

@weyert weyert weyert approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Experimental Release
Development

Successfully merging this pull request may close these issues.
10 participants
@reyang @weyert @jsuereth @carlosalberto @jmacd @tigrannajaryan @cijothomas @arminru @pirgeo @yurishkuro