-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update env vars in spec compliance matrix #1827
Conversation
@open-telemetry/dotnet-maintainers We need at least one approval from you ;) |
|OTEL_LOG_LEVEL | - | - | + | [-][py1059] | + | + | - | | - | - | - | | ||
|OTEL_PROPAGATORS | - | + | | + | + | + | - | - | - | - | - | | ||
|OTEL_BSP_* | - | + | | + | + | + | - | + | - | - | - | | ||
|OTEL_EXPORTER_OTLP_* | + | + | | + | + | - | - | + | - | - | - | | ||
|OTEL_EXPORTER_JAEGER_* | - | | | | | - | - | | - | - | - | | ||
|OTEL_EXPORTER_JAEGER_* | + | | | | | - | - | | - | + | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the docs in
https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.Jaeger#environment-variables
only 2 out of the 6 env vars defined in
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#jaeger-exporter
are supported by otel-dotnet.
Should we state the env vars individually so this is clear or otherwise indicate that it's only partially supported?
There might also be more to come which would void the current +
indicators again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for .NET support in Jaeger. I do like @arminru's idea to break out the individual vars for clarity + future-proofing.
I think it would be better to be done in a separate PR. Especially that it would need probably a review from all SIG maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break out the individual vars for clarity + future-proofing
I think it would be better to be done in a separate PR. Especially that it would need probably a review from all SIG maintainers.
@pellared Makes sense 👍
What
OTEL_SERVICE_NAME
is supported by OTel Go: sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector opentelemetry-go#1969OTEL_EXPORTER_JAEGER_*
are supported by OTel Go: https://github.com/open-telemetry/opentelemetry-go/tree/main/exporters/jaegerOTEL_EXPORTER_JAEGER_*
are supported by OTel .NET: https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.JaegerPTAL: @Aneurysm9 @MrAlias @cijothomas