Added mobile carrier info related semantic conventions to span spec #1669
Conversation
| | `net.host.carrier.name` | string | Name of the mobile carrier. | `sprint` | No | | ||
| | `net.host.carrier.mcc` | string | [Mobile country code](https://en.wikipedia.org/wiki/Mobile_country_code) | `310` | No | | ||
| | `net.host.carrier.mnc` | string | [Mobile network code](https://en.wikipedia.org/wiki/Mobile_country_code) | `001` | No | | ||
| | `net.host.carrier.icc` | string | [ISO country code (two character)](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2) | `DE` | No | |
There was a problem hiding this comment.
These are not "general network connection attributes", but are very specific to mobile clients.
There was a problem hiding this comment.
I think the "general" in the title is more about "low-level networking" as opposed to "protocol-specific attributes".
In any case, I think if we make them span attributes (which seems to be the best currently available option) then putting them under net.host is sensible.
Also net.host.connection_type would make sense for other clients as well.
There was a problem hiding this comment.
@iNikem do you think these should be placed in a different semantic convention document, specifically for mobile?
There was a problem hiding this comment.
Semantic conventions are mostly edited in the YAML sources from which the markdown is then generated. See https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions
arminru
added
area:semantic-conventions
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Hey @bryce-b Want to iterate over the comments? I'd like to see this up to date and hopefully merged ;) |
|
Ping @bryce-b |
|
Please re-open if you would like to resume this work. |
Fixes #
Adds semantic conventions defining mobile carrier data defined in #1647
Changes
net.host.carrier.*net.host.connection_typeRelated issues #
#1647 :
Add semantic convention for describing network connectivity conditions