-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details to UpDownCounter API #1665
Merged
SergeyKanzhelev
merged 8 commits into
open-telemetry:main
from
reyang:reyang/updowncounter
May 4, 2021
Merged
Add details to UpDownCounter API #1665
SergeyKanzhelev
merged 8 commits into
open-telemetry:main
from
reyang:reyang/updowncounter
May 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Apr 30, 2021
jmacd
approved these changes
May 1, 2021
jkwatson
reviewed
May 1, 2021
jsuereth
approved these changes
May 1, 2021
bogdandrutu
approved these changes
May 3, 2021
Co-authored-by: John Watson <[email protected]>
cijothomas
approved these changes
May 3, 2021
All requirements for merge satisfied. Merging |
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add details to UpDownCounter API * add examples * fix typo * fix typo * update example * indentation * Update specification/metrics/new_api.md Co-authored-by: John Watson <[email protected]> Co-authored-by: John Watson <[email protected]> Co-authored-by: Sergey Kanzhelev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1617.
Changes
Added details to the Histogram instrument. In #1617 these were left as TODO.