Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource to ShouldSample. #1658

Closed
wants to merge 5 commits into from
Closed

Add Resource to ShouldSample. #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
235bcaa
Add InstrumentationLibrary and Resource to ShouldSample.
Oberon00 Apr 28, 2021
c0115ac
Fill in PR#.
Oberon00 Apr 28, 2021
f88076c
Merge branch 'main' into should-sample-instlib-resource
Oberon00 May 6, 2021
c124837
Merge branch 'main' into should-sample-instlib-resource
Oberon00 Aug 10, 2021
6282d52
Merge branch 'main' into should-sample-instlib-resource
Oberon00 Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ release.
([#1893](https://github.com/open-telemetry/opentelemetry-specification/pull/1893))
- Add InstrumentationLibrary to Sampler.ShouldSample.
([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850))
- Add Resource to Sampler.ShouldSample.
([#1658](https://github.com/open-telemetry/opentelemetry-specification/pull/1658))

### Metrics

Expand Down
1 change: 1 addition & 0 deletions spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ formats is required. Implementing more than one format is optional.
| Allow samplers to modify tracestate | | + | + | | + | + | + | | + | + | - | + |
| ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + |
| ShouldSample gets InstrumentationLibrary | | | | | | | | | | | | |
| ShouldSample gets Resource | | | | | | | | | | | | |
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | + | - | + |
| [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | + | | + |
| [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | - | | + |
Expand Down
1 change: 1 addition & 0 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ Returns the sampling Decision for a `Span` to be created.
* Collection of links that will be associated with the `Span` to be created.
Typically useful for batch operations, see
[Links Between Spans](../overview.md#links-between-spans).
* `Resource` of the `Span` to be created.
Oberon00 marked this conversation as resolved.
Show resolved Hide resolved
* `InstrumentationLibrary` (name and version) of the `Span` to be created.
Oberon00 marked this conversation as resolved.
Show resolved Hide resolved

Note: Implementations may "bundle" all or several arguments together in a single
Expand Down