Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_EXPORTER_ZIPKIN_TIMEOUT environment variable #1636

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

srikanthccv
Copy link
Member

OTLP and Jaeger exporters have timeout environment variable. It would be nice and consistent to have same for Zipkin.

@srikanthccv srikanthccv requested review from a team April 22, 2021 16:50
@carlosalberto
Copy link
Contributor

Please also reset the related Zipkin section in the spec compliance matrix, as done here: 7594086#diff-365889b493dd3ec92c03576f3a4c8acb75055ec69141fa6111204f037796a6eaR137

cc @anuraaga

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants